[all-commits] [llvm/llvm-project] 7cbf95: [libc++][test] Avoid using `allocator<const T>` (#...

Andres Villegas via All-commits all-commits at lists.llvm.org
Mon Nov 27 17:37:37 PST 2023


  Branch: refs/heads/users/avillega/main.sanitizer_symbolizer-rendercontextual-elements-for-symbolizer-markup
  Home:   https://github.com/llvm/llvm-project
  Commit: 7cbf9598cc6f207a268599cea636533a5c7b2dbd
      https://github.com/llvm/llvm-project/commit/7cbf9598cc6f207a268599cea636533a5c7b2dbd
  Author: Stephan T. Lavavej <stl at nuwen.net>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M libcxx/test/std/containers/views/mdspan/MinimalElementType.h

  Log Message:
  -----------
  [libc++][test] Avoid using `allocator<const T>` (#73545)

Found while running libc++'s test suite with MSVC's STL.

MSVC's STL rejects `allocator<const T>`. This may or may not be
justified by the current Standardese (it was bogus in the C++03 era),
but it's how we reject usage like `vector<const T>`.

A bunch of `mdspan` tests are failing for us because some centralized
machinery is using `allocator<const T>`. Testing that `mdspan` and its
associated types work properly with `const T` is good and necessary, but
directly allocating `const T` is what's a problem for MSVC's STL. I'd
like to ask for a very targeted change here that preserves all of the
test coverage but changes how `ElementPool` interacts with `allocator`.

This intentionally leaves `ElementPool::get_ptr()` returning `T*`
(pointer-to-possibly-const), so there's no externally visible
difference.


  Commit: 17ec364b1b338b6bee5a65a886d0fe75089e6bb9
      https://github.com/llvm/llvm-project/commit/17ec364b1b338b6bee5a65a886d0fe75089e6bb9
  Author: Maksim Levental <maksim.levental at gmail.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M mlir/python/mlir/_mlir_libs/__init__.py
    M mlir/python/mlir/dialects/python_test.py
    M mlir/python/mlir/ir.py
    M mlir/test/python/dialects/python_test.py
    M mlir/test/python/lib/PythonTestModule.cpp

  Log Message:
  -----------
  [mlir][python] enable registering dialects with the default `Context` (#72488)


  Commit: 79cb594fdf15c4bb8fc357b615210e6e57eb1c26
      https://github.com/llvm/llvm-project/commit/79cb594fdf15c4bb8fc357b615210e6e57eb1c26
  Author: Aart Bik <39774503+aartbik at users.noreply.github.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensor.h
    M mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

  Log Message:
  -----------
  [mlir][sparse] remove unused COO method (#73595)

step closer towards moving all type related methods into encoding and/or
sparse tensor type class


  Commit: d3143a09acb30f9d3978373d20d67d2c78ce07a9
      https://github.com/llvm/llvm-project/commit/d3143a09acb30f9d3978373d20d67d2c78ce07a9
  Author: Douglas Yung <douglas.yung at sony.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M clang/test/CodeGen/SystemZ/systemz-ppa2.c

  Log Message:
  -----------
  Add `REQUIRES: systemz-registered-target` to test added in #68926 (9a38a72).


  Commit: 8b3944ca19645df13b0800336de2bac77ddb60b0
      https://github.com/llvm/llvm-project/commit/8b3944ca19645df13b0800336de2bac77ddb60b0
  Author: Andres Villegas <andresvi at google.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_flags.inc
    M compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.cpp
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.cpp
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.h
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cpp

  Log Message:
  -----------
  [sanitizer_symbolizer] Add initial symbolizer markup support for linux.

This is part of a stack of PRs to add support for symbolizer
markup in linux.

You can check the symbolizer markup specification at:
https://llvm.org/docs/SymbolizerMarkupFormat.html

Reviewers: vitalybuka, PiJoules

Reviewed By: vitalybuka

Pull Request: https://github.com/llvm/llvm-project/pull/73193


  Commit: 8795eefc5029569b56b757269e4bec19c01a5b63
      https://github.com/llvm/llvm-project/commit/8795eefc5029569b56b757269e4bec19c01a5b63
  Author: Andres Villegas <andresvi at google.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M clang/test/CodeGen/SystemZ/systemz-ppa2.c
    M libcxx/test/std/containers/views/mdspan/MinimalElementType.h
    M mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensor.h
    M mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
    M mlir/python/mlir/_mlir_libs/__init__.py
    M mlir/python/mlir/dialects/python_test.py
    M mlir/python/mlir/ir.py
    M mlir/test/python/dialects/python_test.py
    M mlir/test/python/lib/PythonTestModule.cpp

  Log Message:
  -----------
  [𝘀𝗽𝗿] changes introduced through rebase

Created using spr 1.3.4

[skip ci]


Compare: https://github.com/llvm/llvm-project/compare/738ef5c96d18...8795eefc5029


More information about the All-commits mailing list