[all-commits] [llvm/llvm-project] 93e156: [DAG] Fix a miscompile in insert_subvector undef (...

[michaelrj-google via All-commits]

  Branch: refs/heads/users/avillega/main.sanitizer_symbolizer-add-initial-symbolizer-markup-support-for-linux
  Home:   https://github.com/llvm/llvm-project
  Commit: 93e156833bfadfbabfa5be2afad4f002c019257f
      https://github.com/llvm/llvm-project/commit/93e156833bfadfbabfa5be2afad4f002c019257f
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/RISCV/rvv/insert-subvector.ll

  Log Message:
  -----------
  [DAG] Fix a miscompile in insert_subvector undef (insert_subvector undef, ..), idx combine (#73587)

The combine was implicitly assuming that the index on the outer
insert_subvector meant the same thing when the source was switched to be
the index of the inner insert_subvector. This is not true if the
innermost sub-vector is fixed, and the outer subvector is scalable.

I could do a less restrictive fix here - i.e. allow the case where the
scalability of the subvectors are the same - but there's no test
coverage which shows this transform actually has profit. Given that, go
for the simplest fix.


  Commit: 9a7f4bde2489f6529d336998e2c3fe902a1d864a
      https://github.com/llvm/llvm-project/commit/9a7f4bde2489f6529d336998e2c3fe902a1d864a
  Author: Jacob Yu <pingshiyu at gmail.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/Arith/IR/ArithBase.td
    M mlir/include/mlir/Dialect/Arith/IR/ArithOps.td

  Log Message:
  -----------
  [mlir][arith] doc updates for ub semantics, and int representations (#72932)

Following the discussions in this thread,
https://discourse.llvm.org/t/some-question-on-the-semantics-of-the-arith-dialect/74861,
here are some updates to the documented semantics of Arith.
Added are clarifications on poison behaviour, UBs, overflow semantics,
and the underlying two's complement representation used for integers

Co-authored-by: kuhar <jakubk at openxla.org>
Co-authored-by: math-fehr <mathieu.fehr at gmail.com>


  Commit: 52b413f25ae79b07df88c0224adec4a6d7dabecc
      https://github.com/llvm/llvm-project/commit/52b413f25ae79b07df88c0224adec4a6d7dabecc
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-fp-buildvec.ll
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-buildvec.ll

  Log Message:
  -----------
  [RISCV] Precommit tests for buildvector lowering with exact VLEN


  Commit: 67268da61aa2f8b24172907ee6f8d9250ee18b65
      https://github.com/llvm/llvm-project/commit/67268da61aa2f8b24172907ee6f8d9250ee18b65
  Author: michaelrj-google <71531609+michaelrj-google at users.noreply.github.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl

  Log Message:
  -----------
  [libc][bazel] Add copts to libc_support_library (#73591)

Most libc_support_library calls are for header-only libraries, but there
are a few that have .cpp files. This patch adds the same base copts to
these that libc_function already has.


  Commit: 6987cc03e9a5ff15fbe844219b196f4428b179f4
      https://github.com/llvm/llvm-project/commit/6987cc03e9a5ff15fbe844219b196f4428b179f4
  Author: michaelrj-google <71531609+michaelrj-google at users.noreply.github.com>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-fp-buildvec.ll
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-buildvec.ll
    M llvm/test/CodeGen/RISCV/rvv/insert-subvector.ll
    M mlir/include/mlir/Dialect/Arith/IR/ArithBase.td
    M mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
    M utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl

  Log Message:
  -----------
  [𝘀𝗽𝗿] changes introduced through rebase

Created using spr 1.3.4

[skip ci]


Compare: https://github.com/llvm/llvm-project/compare/1ec338635a47...6987cc03e9a5