[all-commits] [llvm/llvm-project] 79b033: [llvm] Disable HandleLLVMOptions in runtimes mode ...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Nov 27 06:12:50 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 79b03306af5c11d354fa90db8bfd7818cd811ef5
      https://github.com/llvm/llvm-project/commit/79b03306af5c11d354fa90db8bfd7818cd811ef5
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M runtimes/CMakeLists.txt

  Log Message:
  -----------
  [llvm] Disable HandleLLVMOptions in runtimes mode (#73031)

Summary:
There are a few default options that LLVM adds that can be problematic
for runtimes builds. These options are generally intended to handle
building LLVM itself, but are also added when building in a runtimes
mode. One such issue I've run into is that in `libc` we deliberately use
`--target` to use a different device toolchain, which doesn't support
some linker arguments passed via `-Wl`. This is observed in
https://github.com/llvm/llvm-project/pull/73030 when attempting to use
these options.

This patch completely removes these default arguments.

The consensus is that any issues created by this patch should ultimately
be solved on a per-runtime basis.




More information about the All-commits mailing list