[all-commits] [llvm/llvm-project] 272085: [DomTree] Remove unnecessary domtree level check i...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 272085f10bfaa33349682a9e4d08c990c159355d
      https://github.com/llvm/llvm-project/commit/272085f10bfaa33349682a9e4d08c990c159355d
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Support/GenericDomTreeConstruction.h

  Log Message:
  -----------
  [DomTree] Remove unnecessary domtree level check in SemiNCA (NFC) (#73107)

runSemiNCA() currently checks that the ReverseChildren are below
MinLevel in the DT, which is used when performing incremental updates.

However, ReverseChildren is populated during runDFS with only the
predecessors that are part of that DFS walk, which will itself be level
limited in the relevant cases. As such, I don't believe that this should
be checked during runSemiNCA().

This code probably dates back to a time when predecessors were not
cached during runDFS and as such not limited to the visited subtree
only.