[all-commits] [llvm/llvm-project] f5832b: [libc++][test] Cleanup typos and unnecessary semic...

[Stephan T. Lavavej via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f5832bab6f5024cabe32a9f668b7f44e6b7cfef5
      https://github.com/llvm/llvm-project/commit/f5832bab6f5024cabe32a9f668b7f44e6b7cfef5
  Author: Stephan T. Lavavej <stl at nuwen.net>
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
    M libcxx/test/libcxx/algorithms/alg.modifying.operations/copy_move_nontrivial.pass.cpp
    M libcxx/test/libcxx/algorithms/pstl.robust_against_customization_points_not_working.pass.cpp
    M libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp
    M libcxx/test/libcxx/diagnostics/bit.nodiscard_extensions.compile.pass.cpp
    M libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp
    M libcxx/test/libcxx/diagnostics/format.nodiscard_extensions.compile.pass.cpp
    M libcxx/test/libcxx/diagnostics/pstl.nodiscard_extensions.compile.pass.cpp
    M libcxx/test/libcxx/diagnostics/ranges.nodiscard_extensions.compile.pass.cpp
    M libcxx/test/libcxx/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp
    M libcxx/test/libcxx/utilities/meta/stress_tests/stress_test_variant_overloads_impl.sh.cpp
    M libcxx/test/libcxx/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_piecewise_pair.pass.cpp
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.remove/ranges.remove.pass.cpp
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.iterator.pass.cpp
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.range.pass.cpp
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.unary.pass.cpp
    M libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp
    M libcxx/test/std/algorithms/alg.nonmodifying/alg.foreach/ranges.for_each_n.pass.cpp
    M libcxx/test/std/algorithms/alg.sorting/alg.partitions/ranges.is_partitioned.pass.cpp
    M libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
    M libcxx/test/std/concepts/concepts.object/semiregular.compile.pass.cpp
    M libcxx/test/std/containers/sequences/deque/deque.modifiers/push_back_exception_safety.pass.cpp
    M libcxx/test/std/containers/sequences/deque/deque.modifiers/push_front_exception_safety.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/push_front_exception_safety.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/remove_if.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/unique_pred.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.modifiers/push_back_exception_safety.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.modifiers/push_front_exception_safety.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.ops/remove_if.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.ops/unique_pred.pass.cpp
    M libcxx/test/std/containers/views/mdspan/ConvertibleToIntegral.h
    M libcxx/test/std/containers/views/mdspan/CustomTestLayouts.h
    M libcxx/test/std/containers/views/mdspan/extents/CtorTestCombinations.h
    M libcxx/test/std/containers/views/mdspan/extents/ctad.pass.cpp
    M libcxx/test/std/containers/views/mdspan/extents/ctor_default.pass.cpp
    M libcxx/test/std/containers/views/mdspan/extents/ctor_from_array.pass.cpp
    M libcxx/test/std/containers/views/mdspan/extents/ctor_from_span.pass.cpp
    M libcxx/test/std/containers/views/mdspan/mdspan/CustomTestAccessors.h
    M libcxx/test/std/containers/views/mdspan/mdspan/types.pass.cpp
    M libcxx/test/std/experimental/simd/simd.class/simd_ctor_default.pass.cpp
    M libcxx/test/std/experimental/simd/simd.mask.class/simd_mask_ctor_default.pass.cpp
    M libcxx/test/std/input.output/syncstream/syncbuf/sputc.pass.cpp
    M libcxx/test/std/input.output/syncstream/syncbuf/sputn.pass.cpp
    M libcxx/test/std/input.output/syncstream/syncbuf/syncstream.syncbuf.assign/assign.pass.cpp
    M libcxx/test/std/numerics/numarray/class.gslice/gslice.cons/default.pass.cpp
    M libcxx/test/std/numerics/numarray/class.gslice/gslice.cons/start_size_stride.pass.cpp
    M libcxx/test/std/ranges/range.adaptors/range.drop/dangling.cache.pass.cpp
    M libcxx/test/std/ranges/range.adaptors/range.join.view/sentinel/ctor.other.pass.cpp
    M libcxx/test/std/ranges/range.adaptors/range.reverse/begin.pass.cpp
    M libcxx/test/std/ranges/range.adaptors/range.zip/end.pass.cpp
    M libcxx/test/std/ranges/range.adaptors/range.zip/iterator/iter_move.pass.cpp
    M libcxx/test/std/ranges/range.adaptors/range.zip/iterator/iter_swap.pass.cpp
    M libcxx/test/std/ranges/range.adaptors/range.zip/sentinel/minus.pass.cpp
    M libcxx/test/std/ranges/range.adaptors/range.zip/types.h
    M libcxx/test/std/ranges/range.factories/range.repeat.view/views_repeat.pass.cpp
    M libcxx/test/std/re/re.const/re.matchflag/match_flag_type.pass.cpp
    M libcxx/test/std/re/re.const/re.synopt/syntax_option_type.pass.cpp
    M libcxx/test/std/strings/string.view/string.view.comparison/common_type_specialization.pass.cpp
    M libcxx/test/std/thread/futures/futures.async/async.pass.cpp
    M libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_duration.pass.cpp
    M libcxx/test/std/time/time.syn/formatter.file_time.pass.cpp
    M libcxx/test/std/time/time.syn/formatter.sys_time.pass.cpp
    M libcxx/test/std/time/time.zone/time.zone.db/time.zone.db.list/erase_after.compile.pass.cpp
    M libcxx/test/std/utilities/expected/expected.expected/assign/assign.U.pass.cpp
    M libcxx/test/std/utilities/expected/expected.expected/assign/emplace.intializer_list.pass.cpp
    M libcxx/test/std/utilities/expected/expected.expected/swap/free.swap.pass.cpp
    M libcxx/test/std/utilities/expected/expected.expected/swap/member.swap.pass.cpp
    M libcxx/test/std/utilities/expected/expected.void/swap/free.swap.pass.cpp
    M libcxx/test/std/utilities/expected/expected.void/swap/member.swap.pass.cpp
    M libcxx/test/std/utilities/expected/types.h
    M libcxx/test/std/utilities/format/format.formattable/concept.formattable.compile.pass.cpp
    M libcxx/test/std/utilities/format/format.formatter/format.context/format.context/ctor.pass.cpp
    M libcxx/test/std/utilities/format/format.formatter/format.context/format.context/locale.pass.cpp
    M libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp
    M libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
    M libcxx/test/std/utilities/format/format.functions/format_tests.h
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.enab/enable_shared_from_this.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter_allocator.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared.lwg2070.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/make_shared.private.compile.fail.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.obs/op_bool.pass.cpp
    M libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move.pass.cpp
    M libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc_UTypes.pass.cpp
    M libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc_const_Types.verify.cpp
    M libcxx/test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/tracking_mem_res.h
    M libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair_U_V.pass.cpp
    M libcxx/test/support/assert_macros.h
    M libcxx/test/support/boolean_testable.h
    M libcxx/test/support/concat_macros.h
    M libcxx/test/support/copy_move_types.h
    M libcxx/test/support/iterator_traits_cpp17_iterators.h
    M libcxx/test/support/test_container_comparisons.h
    M libcxx/test/support/test_iterators.h

  Log Message:
  -----------
  [libc++][test] Cleanup typos and unnecessary semicolons (#73435)

I've structured this into a series of commits for even easier reviewing,
if that helps. I could easily split this up into separate PRs if
desired, but as this is low-risk with simple edits, I thought one PR
would be easiest.

* Drop unnecessary semicolons after function definitions.
* Cleanup comment typos.
* Cleanup `static_assert` typos.
* Cleanup test code typos.
+ There should be no functional changes, assuming I've changed all
occurrences.
* ~~Fix massive test code typos.~~
+ This was a real problem, but needed more surgery. I reverted those
changes here, and @philnik777 is fixing this properly with #73444.
* clang-formatting as requested by the CI.