[all-commits] [llvm/llvm-project] 1b7058: [mlir][spirv] Update integer dot product op syntax...

Jakub Kuderski via All-commits all-commits at lists.llvm.org
Sun Nov 26 16:43:14 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b70587ca13bc1d372ddd3928818b7d774e21595
      https://github.com/llvm/llvm-project/commit/1b70587ca13bc1d372ddd3928818b7d774e21595
  Author: Jakub Kuderski <jakub at nod-labs.com>
  Date:   2023-11-26 (Sun, 26 Nov 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVIntegerDotProductOps.td
    M mlir/lib/Dialect/SPIRV/IR/IntegerDotProductOps.cpp
    M mlir/test/Conversion/VectorToSPIRV/vector-reduction-to-spirv-dot-prod.mlir
    M mlir/test/Dialect/SPIRV/IR/availability.mlir
    M mlir/test/Dialect/SPIRV/IR/integer-dot-product-ops.mlir

  Log Message:
  -----------
  [mlir][spirv] Update integer dot product op syntax (#73468)

Make the syntax more concise and aligned with the `spirv.Dot` syntax in
https://github.com/llvm/llvm-project/pull/73466.

Move some type verification from C++ to ODS.

Regexes to update existing code and tests:
`(\s*\{format\s+=\s+#spirv.packed_vector_format([^}]+)\})`
==>
`, $2`

`(spirv.[SU]+Dot[a-zA-Z]*[^:]+:)(\s*\(([^,]+),[^\)]+\))(.+)`
==>
`$1 $3$4`




More information about the All-commits mailing list