[all-commits] [llvm/llvm-project] 6248c2: [mlir] Workaround for export lib generation on Win...

Ivan Butygin via All-commits all-commits at lists.llvm.org
Thu Nov 23 04:23:15 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6248c24876d81d83544af02399d46813dbea869c
      https://github.com/llvm/llvm-project/commit/6248c24876d81d83544af02399d46813dbea869c
  Author: Ivan Butygin <ivan.butygin at gmail.com>
  Date:   2023-11-23 (Thu, 23 Nov 2023)

  Changed paths:
    M mlir/lib/ExecutionEngine/ArmSMEStubs.cpp
    M mlir/lib/ExecutionEngine/CMakeLists.txt

  Log Message:
  -----------
  [mlir] Workaround for export lib generation on Windows for `mlir_arm_sme_abi_stubs` (#73147)

Using mlir cmake in downstream project fails with error
```
CMake Error at D:/projs/llvm/llvm-install/lib/cmake/mlir/MLIRTargets.cmake:2537 (message):
  The imported target "mlir_arm_sme_abi_stubs" references the file

     "D:/projs/llvm/llvm-install/lib/mlir_arm_sme_abi_stubs.lib"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "D:/projs/llvm/llvm-install/lib/cmake/mlir/MLIRTargets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  D:/projs/llvm/llvm-install/lib/cmake/mlir/MLIRConfig.cmake:37 (include)
  mlir/CMakeLists.txt:5 (find_package)
```

Windows cmake needs export libaries but it seems they are only being
generated if you have at least one exported symbol.
Add export attributes to symbols.

Not sure what the best approach to fix this (probably we should just
disable this lib on windows entirely), but it fixed things for me
locally.




More information about the All-commits mailing list