[all-commits] [llvm/llvm-project] a855a1: [compiler-rt] Fix interceptors with Solaris as (#7...

Marco Elver via All-commits all-commits at lists.llvm.org
Tue Nov 21 11:48:16 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a855a16a02e76a0f4192c038bb64f3773947a2f7
      https://github.com/llvm/llvm-project/commit/a855a16a02e76a0f4192c038bb64f3773947a2f7
  Author: Marco Elver <elver at google.com>
  Date:   2023-11-21 (Tue, 21 Nov 2023)

  Changed paths:
    M compiler-rt/lib/interception/interception.h
    M compiler-rt/lib/sanitizer_common/sanitizer_asm.h

  Log Message:
  -----------
  [compiler-rt] Fix interceptors with Solaris as (#72973)

Jakub Jelínek reports:

As mentioned in https://gcc.gnu.org/PR112563, the new DECLARE_WRAPPER
macro
added in 37445e9 and ammended in 85d3873 doesn't work on SPARC/Solaris
with
  Solaris as.

While clang and GNU as when used from GCC seems to be forgiving on most
architectures and allow both %function and @function (with the latter
not being
allowed on ARM/AArch64 I believe because @ is assembler comment start
there),
  Solaris as doesn't allow the %function form.

Fix it by using %function only for ARM.

Co-developed-by: Jakub Jelínek <jakub at redhat.com>
Reported-by: Jakub Jelínek <jakub at redhat.com>
Closes: https://github.com/llvm/llvm-project/issues/72970




More information about the All-commits mailing list