[all-commits] [llvm/llvm-project] 26a0b2: Make MLIR Value more consistent in terms of `const...

[Mehdi Amini via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26a0b277369adc31b162b1cc38b1a712bc10c1a0
      https://github.com/llvm/llvm-project/commit/26a0b277369adc31b162b1cc38b1a712bc10c1a0
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M flang/lib/Optimizer/Dialect/FIRDialect.cpp
    M mlir/docs/Tutorials/Toy/Ch-4.md
    M mlir/examples/toy/Ch4/mlir/Dialect.cpp
    M mlir/examples/toy/Ch5/mlir/Dialect.cpp
    M mlir/examples/toy/Ch6/mlir/Dialect.cpp
    M mlir/examples/toy/Ch7/mlir/Dialect.cpp
    M mlir/include/mlir/IR/Value.h
    M mlir/include/mlir/Transforms/InliningUtils.h
    M mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRV.cpp
    M mlir/lib/Dialect/Func/Extensions/InlinerExtension.cpp
    M mlir/lib/Dialect/LLVMIR/IR/LLVMInlining.cpp
    M mlir/lib/Dialect/Linalg/IR/LinalgDialect.cpp
    M mlir/lib/Dialect/SCF/IR/SCF.cpp
    M mlir/lib/Dialect/SPIRV/IR/SPIRVDialect.cpp
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/lib/IR/Value.cpp
    M mlir/lib/Transforms/Utils/InliningUtils.cpp
    M mlir/test/lib/Dialect/Test/TestDialectInterfaces.cpp

  Log Message:
  -----------
  Make MLIR Value more consistent in terms of `const` "correctness" (NFC) (#72765)

MLIR can't really be const-correct (it would need a `ConstValue` class
alongside the `Value` class really, like `ArrayRef` and
`MutableArrayRef`). This is however making is more consistent: method
that are directly modifying the Value shouldn't be marked const.