[all-commits] [llvm/llvm-project] d32851: [Clang] Fix finding instantiated decls for class t...

[Yuxuan Chen via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d3285123bc9c2e170c8aa7e418c132119bc7aaf1
      https://github.com/llvm/llvm-project/commit/d3285123bc9c2e170c8aa7e418c132119bc7aaf1
  Author: Yuxuan Chen <ych at meta.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
    M clang/test/SemaCXX/template-specialization.cpp

  Log Message:
  -----------
  [Clang] Fix finding instantiated decls for class template specializations during instantiation (#72346)

This change aims to fix
https://github.com/llvm/llvm-project/issues/70375

It appears to me that the logic here should be handling specializations
in general, not just partial specialization. It also seems that both the
comment before the block and the `isInstantiationOf(ClassTemplate,
SpecTemplate)` below agree with my judgement.

The issue might just be a mistake that someone mistaken specialization
as a special case of partial specializations, while it's actually the
other way around.

Needs some experts to comment here if this is the right fix. 

The code that caused clang ICE is added as a test case.