[all-commits] [llvm/llvm-project] abd85c: [libc] Remove the optional arguments for NVPTX con...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Nov 20 15:10:29 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: abd85cd473afedf112bf00630a22382fee4a7853
      https://github.com/llvm/llvm-project/commit/abd85cd473afedf112bf00630a22382fee4a7853
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M libc/startup/gpu/nvptx/start.cpp
    M libc/test/integration/startup/gpu/init_fini_array_test.cpp

  Log Message:
  -----------
  [libc] Remove the optional arguments for NVPTX constructors (#69536)

Summary:
We call the global constructors by function pointer. For whatever reason
the NVPTX architecture relies very specifically on the arguments to the
function pointer invocation matching what the function is implemented
as. This is problematic as most of these constructors are generated
with no arguments. This patch removes the extended arguments that GNU
and LLVM use for the constructors optionally so that it can support the
common case.




More information about the All-commits mailing list