[all-commits] [llvm/llvm-project] 4a0200: [NFC] Simplify the tiling implementation using clo...

MaheshRavishankar via All-commits all-commits at lists.llvm.org
Mon Nov 20 09:06:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4a020018ce7abdee21e976f7ed5746ef2eb2c0fd
      https://github.com/llvm/llvm-project/commit/4a020018ce7abdee21e976f7ed5746ef2eb2c0fd
  Author: MaheshRavishankar <1663364+MaheshRavishankar at users.noreply.github.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
    M mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp
    M mlir/test/Dialect/Tensor/tiling.mlir
    M mlir/test/Interfaces/TilingInterface/tile-and-fuse-using-interface.mlir
    M mlir/test/Interfaces/TilingInterface/tile-using-interface.mlir
    M mlir/test/lib/Interfaces/TilingInterface/TestTilingInterface.cpp

  Log Message:
  -----------
  [NFC] Simplify the tiling implementation using cloning. (#72178)

The current implementation of tiling using `scf.for` is convoluted to
make sure that the destination passing style of the untiled program is
preserved. The addition of support to tile using `scf.forall` (adapted
from the transform operation in Linalg) in
https://github.com/llvm/llvm-project/pull/67083 used cloning of the
tiled operations to better streamline the implementation. This PR adapts
the other tiling methods to use a similar approach, making the
transformations (and handling destination passing style semantics) more
systematic.

---------

Co-authored-by: Abhishek-Varma <avarma094 at gmail.com>




More information about the All-commits mailing list