[all-commits] [llvm/llvm-project] cd8804: [NFC][SROA] Remove implementation details from SRO...

Bruno De Fraine via All-commits all-commits at lists.llvm.org
Mon Nov 20 05:00:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cd88047765a3242f1ebc8d25ec2eeb7752d44867
      https://github.com/llvm/llvm-project/commit/cd88047765a3242f1ebc8d25ec2eeb7752d44867
  Author: Bruno De Fraine <144025007+brunodf-snps at users.noreply.github.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Transforms/Scalar/SROA.h
    M llvm/lib/Transforms/Scalar/SROA.cpp

  Log Message:
  -----------
  [NFC][SROA] Remove implementation details from SROA header (#72846)

This moves the SROA implementation from SROAPass into a separate SROA
class that is defined in the cpp file, and reduces the SROAPass class to
a thin NewPM wrapper. This allows to remove all implementation details
from the SROA header, and the SROALegacyPass can wrap the SROA class
instead of the NewPM SROAPass.

The trigger for this change is a GCC warning about visibility of
implementation details in the SROA header after D138238. Credits to
Nikita Popov for suggesting this reorganization.




More information about the All-commits mailing list