[all-commits] [llvm/llvm-project] 7e65dc: Revert "Apply clang-tidy fixes for misc-include-cl...

ftynse via All-commits all-commits at lists.llvm.org
Mon Nov 20 01:00:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7e65dc72c4251cb7409545686bc2751d50d4efae
      https://github.com/llvm/llvm-project/commit/7e65dc72c4251cb7409545686bc2751d50d4efae
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2023-11-20 (Mon, 20 Nov 2023)

  Changed paths:
    M mlir/lib/Bindings/Python/IRCore.cpp

  Log Message:
  -----------
  Revert "Apply clang-tidy fixes for misc-include-cleaner in IRCore.cpp (NFC)"

This reverts commit 0d109035c29408f06efc148d67aab7e4b2aada5d.

Changes make Python bindings unbuildable without additional cmake
modifications (or modified `$PATH`).

```
/llvm-project/mlir/lib/Bindings/Python/IRCore.cpp:33:10: fatal error: 'funcobject.h' file not found
```

This header is provided by cpython, and we are not looking for that in
cmake.

Moreover, the nature of this change is not very clear to me. Seems to
replace one include with two dozens, presumably because the code is only
using transitively included headers, but the value for readability is
dubious. LLVM is also not strictly following IWYU.




More information about the All-commits mailing list