[all-commits] [llvm/llvm-project] 797b68: Revert "[MC][AsmParser] Diagnose improperly nested...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 797b68c0ba699994e1038ac33d3083541482bf19
      https://github.com/llvm/llvm-project/commit/797b68c0ba699994e1038ac33d3083541482bf19
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-11-19 (Sun, 19 Nov 2023)

  Changed paths:
    M lld/test/COFF/gc-dwarf-eh.s
    M llvm/lib/MC/MCParser/AsmParser.cpp
    R llvm/test/MC/AArch64/cfi-bad-nesting.s

  Log Message:
  -----------
  Revert "[MC][AsmParser] Diagnose improperly nested .cfi frames"

This reverts commit 4323da926f12672daec7f59384bd153a7cf28674.

This broke building libffi for ARM on Windows (and probably Darwin),
where one extern function intentionally falls through to another
one, while sharing one CFI region.

As long as one isn't using .subsections_via_symbols on MachO,
this probably shouldn't be a hard error.

Secondly, the tested pattern only produces an error on MachO and
COFF targets, but not for ELF, making the error case even more
inconsistent.

Reverting this commit for now, to figure out the best way forward.