[all-commits] [llvm/llvm-project] 8a40fc: [mlir][vector] Clean up VectorTransferOpInterface ...

Matthias Springer via All-commits all-commits at lists.llvm.org
Wed Nov 15 17:35:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8a40fcaf357851a7d572bc1a8c314ac277f7ec66
      https://github.com/llvm/llvm-project/commit/8a40fcaf357851a7d572bc1a8c314ac277f7ec66
  Author: Matthias Springer <me at m-sp.org>
  Date:   2023-11-16 (Thu, 16 Nov 2023)

  Changed paths:
    M mlir/include/mlir/Interfaces/VectorInterfaces.td
    M mlir/lib/Dialect/Vector/IR/VectorOps.cpp
    M mlir/lib/Dialect/Vector/Transforms/VectorTransferSplitRewritePatterns.cpp

  Log Message:
  -----------
  [mlir][vector] Clean up VectorTransferOpInterface (#72353)

- Better documentation.
- Rename interface methods: `source` -> `getSource`, `indices` ->
`getIndices`, etc. to conform with MLIR naming conventions. A default
implementation is not needed.
- Turn many interface methods into helper functions. Most of the
previous interface methods were not meant to be overridden, and if some
were overridden without others, the op would be have been broken.




More information about the All-commits mailing list