[all-commits] [llvm/llvm-project] c2a2fd: [DebugInfo][RemoveDIs] Allow for inserting DPValue...

Jeremy Morse via All-commits all-commits at lists.llvm.org
Wed Nov 15 07:55:48 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c2a2fd209e2da4c80e55d11b114d47b8d1eaaa16
      https://github.com/llvm/llvm-project/commit/c2a2fd209e2da4c80e55d11b114d47b8d1eaaa16
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M llvm/lib/IR/Instruction.cpp

  Log Message:
  -----------
  [DebugInfo][RemoveDIs] Allow for inserting DPValues at end() (#72379)

This trivial patch covers a bit of fallout from
https://reviews.llvm.org/D153990, where we moved the storage of trailing
DPValues into LLVMContext rather than being stored in each block. As a
result, you can now get a null DPMarker pointer from the end() iterator
where previously you didn't (and now it has to be explicitly created).

This is a sort-of stopgap measure -- there's another all-singing
all-dancing patch further down the line that refactors all of this so
that we don't allocate a DPMarker for every single Instruction. When
that lands this will all be refactored so that every time we request a
DPMarker, one is created if needs be. That's a performance-fix rather
than a functionality related patch though, so it'll come later.




More information about the All-commits mailing list