[all-commits] [llvm/llvm-project] 808caa: [JITLink][AArch32] Run all error unittests throug ...

[Stefan Gränitz via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 808caa9d4608b4383743043f6dbdab6faf608bcc
      https://github.com/llvm/llvm-project/commit/808caa9d4608b4383743043f6dbdab6faf608bcc
  Author: Stefan Gränitz <stefan.graenitz at gmail.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M llvm/include/llvm/ExecutionEngine/JITLink/aarch32.h
    M llvm/lib/ExecutionEngine/JITLink/ELF_aarch32.cpp
    M llvm/lib/ExecutionEngine/JITLink/aarch32.cpp
    M llvm/unittests/ExecutionEngine/JITLink/AArch32ErrorTests.cpp

  Log Message:
  -----------
  [JITLink][AArch32] Run all error unittests throug main entrypoints (#72091)

Reading implicit addend from a relocation site doesn't require a complete
`LinkGraph` edge. The operation is independent from `TargetSymbol`,
but constructing an `Edge` instance required one. This patch fixes the
inconsistency and simplifies some setup code from the error unittests.

Furthermore this patch prepares for the `Arm`/`Thumb`/`Data` helper
functions to be turned into implementation details. Exposing them in the
API causes unfortunate inconsistencies that we don't want to error-check
all the time, e.g. passing `Thumb_Call` to `readAddendArm()`.