[all-commits] [llvm/llvm-project] 893610: [hwasan] Move __hwasan_thread_enter/__hwasan_threa...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 89361007aa8a44d68f2620570fd4efcc8757f3bb
      https://github.com/llvm/llvm-project/commit/89361007aa8a44d68f2620570fd4efcc8757f3bb
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M compiler-rt/lib/hwasan/hwasan_linux.cpp

  Log Message:
  -----------
  [hwasan] Move __hwasan_thread_enter/__hwasan_thread_exit out of namespace (#72123)

Due to a GCC bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25940),
GCC doesn't consider extern "C" functions with the same name but
different namespace to be the same. As such, the default visibility
attribute (on a declaration outside the namespace) doesn't get applied
to the definition in the namespace and the symbol is not exported.

This came up as an ABI diff when switching between gcc and clang for
compiling compiler-rt.