[all-commits] [llvm/llvm-project] 1f6eb3: [XCOFF]refactor isFunction, NFC (#72232)

Chen Zheng via All-commits all-commits at lists.llvm.org
Tue Nov 14 18:42:12 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f6eb3ca5cb1551b537141fc84827d704917a97b
      https://github.com/llvm/llvm-project/commit/1f6eb3ca5cb1551b537141fc84827d704917a97b
  Author: Chen Zheng <czhengsz at cn.ibm.com>
  Date:   2023-11-15 (Wed, 15 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Object/XCOFFObjectFile.h
    M llvm/lib/Object/XCOFFObjectFile.cpp

  Log Message:
  -----------
  [XCOFF]refactor isFunction, NFC (#72232)

suggested in review of https://github.com/llvm/llvm-project/pull/69553

This is actually not an NFC as isFunction() does not return false for
some "invalid" object, instead it returns the errors to its caller. But
since there is no such invalid object in the LIT tests, so no case
changes.




More information about the All-commits mailing list