[all-commits] [llvm/llvm-project] e6eda6: Recommit changes to global checks (#71171)

[Henrik G. Olsson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e6eda66cbc5ebf424b184506fc6bb27bee3d293f
      https://github.com/llvm/llvm-project/commit/e6eda66cbc5ebf424b184506fc6bb27bee3d293f
  Author: Henrik G. Olsson <hnrklssn at gmail.com>
  Date:   2023-11-13 (Mon, 13 Nov 2023)

  Changed paths:
    A clang/test/utils/update_cc_test_checks/Inputs/annotations.c
    A clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected
    A clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.all.expected
    M clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected
    A clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.no-generated.all.expected
    M clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.no-generated.expected
    A clang/test/utils/update_cc_test_checks/annotations.test
    M clang/test/utils/update_cc_test_checks/check-globals.test
    M clang/test/utils/update_cc_test_checks/generated-funcs.test
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs.ll.generated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs.ll.nogenerated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs_prefix_reuse.ll.generated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs_prefix_reuse.ll.nogenerated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/global_regex.ll.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/various_ir_values.ll.funcsig.globals.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/various_ir_values.ll.funcsig.noglobals.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/various_ir_values.ll.funcsig.transitiveglobals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/various_ir_values.test
    M llvm/utils/UpdateTestChecks/common.py
    M llvm/utils/update_cc_test_checks.py
    M llvm/utils/update_test_checks.py

  Log Message:
  -----------
  Recommit changes to global checks (#71171)

Recommits the changes from https://reviews.llvm.org/D148216.
Explicitly named globals are now matched literally, instead of emitting
a capture group for the name. This resolves #70047.
Metadata and annotations, on the other hand, are captured and matched
against by default, since their identifiers are not stable.

The reasons for revert (#63746) have been fixed:
The first issue, that of duplicated checkers, has already been resolved
in #70050.
This PR resolves the second issue listed in #63746, regarding the order
of named and unnamed globals. This is fixed by recording the index of
substrings containing global values, and sorting the checks according to
that index before emitting them. This results in global value checks
being emitted in the order they were seen instead of being grouped
separately.