[all-commits] [llvm/llvm-project] 215bac: Centralize the code that figures out which memory ...

[Greg Clayton via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 215bacb5dc6e7027402434a14e1153e687a4a1cf
      https://github.com/llvm/llvm-project/commit/215bacb5dc6e7027402434a14e1153e687a4a1cf
  Author: Greg Clayton <gclayton at fb.com>
  Date:   2023-11-11 (Sat, 11 Nov 2023)

  Changed paths:
    M lldb/include/lldb/Target/MemoryRegionInfo.h
    M lldb/include/lldb/Target/Process.h
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
    M lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
    M lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h
    M lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/TraceDumper.cpp
    M lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py

  Log Message:
  -----------
  Centralize the code that figures out which memory ranges to save into core files (#71772)

Prior to this patch, each core file plugin (ObjectFileMachO.cpp and
ObjectFileMinindump.cpp) would calculate the address ranges to save in
different ways. This patch adds a new function to Process.h/.cpp:

```
Status Process::CalculateCoreFileSaveRanges(lldb::SaveCoreStyle core_style, CoreFileMemoryRanges &ranges);
```

The patch updates the ObjectFileMachO::SaveCore(...) and
ObjectFileMinindump::SaveCore(...) to use same code. This will allow
core files to be consistent with the lldb::SaveCoreStyle across
different core file creators and will allow us to add new core file
saving features that do more complex things in future patches.