[all-commits] [llvm/llvm-project] 0f8d3e: Fix a little thinko in sending events to secondary...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0f8d3e62d3fe3db905ac94e5d11fee87553c7794
      https://github.com/llvm/llvm-project/commit/0f8d3e62d3fe3db905ac94e5d11fee87553c7794
  Author: jimingham <jingham at apple.com>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M lldb/source/Utility/Broadcaster.cpp

  Log Message:
  -----------
  Fix a little thinko in sending events to secondary listeners. (#71997)

If `unique` is true, I was redoing the uniqueness check for the
secondary listeners, which is racy since a "duplicate" event could come
in between deciding to send the event to the main listener and checking
for the shadow listener, and then the two streams would get out of sync.

There's not a good way to write a direct test for this, but the
test_shadow_listeners test has been flakey and this is the only racy
part of that system I can find. So the test would be that that
test_shadow_listeners becomes not flakey.