[all-commits] [llvm/llvm-project] 601e8f: Rehome libcxx-builder docker image & attempt gentl...

[Eric via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 601e8fdd28e50bdd8ccac24ec2a3e330b3651937
      https://github.com/llvm/llvm-project/commit/601e8fdd28e50bdd8ccac24ec2a3e330b3651937
  Author: Eric <eric at efcs.ca>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M libcxx/utils/ci/Dockerfile
    A libcxx/utils/ci/docker-compose.yml
    M libcxx/utils/ci/run-buildbot-container
    M libcxx/utils/ci/vendor/android/Dockerfile

  Log Message:
  -----------
  Rehome libcxx-builder docker image & attempt gentler termination. (#71604)

There are three changes present in this PR.

1. Use github packages for libcxx-builder rather than dockerhub.

The ldionne/libcxx-builder image will now be hosted at
ghcr.io/libcxx/libcxx-builder. This has the benefit of allowing members
of the github org to push new versions.

In the future I hope to add github actions to rebuild the image as
needed.

2. Add docker-compose file

The compose file allows to to specify the package repository, so that
users can simply write 'docker compose build' and 'docker compose push'.

It also gives us a centralized place to manage version arguments which
change frequently.

3. Use non-shell CMD form.

This may help the google libcxx builders disconnect more gracefully as
the shell form of CMD may eat the shutdown signal. I'm hoping this
corrects inaccurate agent counts from the buildkite API, since when the
VM's terminate, they do so without signaling it to buildkite, which
hangs around waiting for them to reconnect. It's likely more changes
will be needed though.

---------

Co-authored-by: Mark de Wever <zar-rpg at xs4all.nl>