[all-commits] [llvm/llvm-project] 148626: [lldb] Change interface of StructuredData::Array::...

[Alex Langford via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1486264d5fad0ef7d76a44f6358390cf41218c7e
      https://github.com/llvm/llvm-project/commit/1486264d5fad0ef7d76a44f6358390cf41218c7e
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    M lldb/include/lldb/Utility/StructuredData.h
    M lldb/source/Breakpoint/Breakpoint.cpp
    M lldb/source/Breakpoint/BreakpointOptions.cpp
    M lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp
    M lldb/source/Breakpoint/BreakpointResolverName.cpp
    M lldb/source/Commands/CommandObjectBreakpoint.cpp
    M lldb/source/Core/SearchFilter.cpp
    M lldb/source/Target/DynamicRegisterInfo.cpp
    M lldb/unittests/tools/lldb-server/tests/MessageObjects.cpp

  Log Message:
  -----------
  [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsString (#71613)

This patch changes the interface of
StructuredData::Array::GetItemAtIndexAsString to return a
`std::optional<llvm::StringRef>` instead of taking an out parameter.
More generally, this commit serves as proposal that we change all of the
sibling APIs (`GetItemAtIndexAs`) to do the same thing. The reason this
isn't one giant patch is because it is rather unwieldy changing just one
of these, so if this is approved, I will do all of the other ones as
individual follow-ups.