[all-commits] [llvm/llvm-project] b90cba: [NFC][RemoveDIs] Shuffle header inclusions for "ne...

Jeremy Morse via All-commits all-commits at lists.llvm.org
Thu Nov 9 05:35:21 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b90cba10f9ca3115ccd90f17295367aedfdc6260
      https://github.com/llvm/llvm-project/commit/b90cba10f9ca3115ccd90f17295367aedfdc6260
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    M llvm/include/llvm/IR/BasicBlock.h
    M llvm/include/llvm/IR/DebugProgramInstruction.h
    M llvm/lib/IR/DebugProgramInstruction.cpp

  Log Message:
  -----------
  [NFC][RemoveDIs] Shuffle header inclusions for "new" debug-info

BasicBlock.h and Instruction.h will eventually need to include
DebugProgramInstruction.h so that debug-info attached to instructions can
be enumerated and cloned. Originally including it made compiling clang
much slower, I think I've pinned that down as being the inclusion of
DebugInfoMetadata.h causing ~every LLVM translation unit to parse
all the debug-info classes.

This patch avoids that by shifting some functions into the cpp file rather
than the header, and restores the inclusion of DebugProgramInstruction.h in
BasicBlock.h so that the rest of the RemoveDIs functionality can land.




More information about the All-commits mailing list