[all-commits] [llvm/llvm-project] 919f5e: [lldb] Add Checksum to FileSpec (#71457)

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Nov 8 20:12:09 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 919f5ef4621edcfd9e9793e1363df53eef3e89d5
      https://github.com/llvm/llvm-project/commit/919f5ef4621edcfd9e9793e1363df53eef3e89d5
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2023-11-08 (Wed, 08 Nov 2023)

  Changed paths:
    M lldb/include/lldb/Utility/FileSpec.h
    M lldb/source/Utility/FileSpec.cpp
    M lldb/unittests/Utility/FileSpecTest.cpp

  Log Message:
  -----------
  [lldb] Add Checksum to FileSpec (#71457)

Store a Checksum in FileSpec. Its purpose is to store the MD5 hash that
was added to the DWARF 5 line table.

This increases the size of a FileSpec from 24 to 40 bytes. The
alternative is to introduce a new SupportFile abstraction for a FileSpec
+ Checksum but that would require a corresponding SupportFileList class.
During review we decided that wasn't worth it, but that's something we
can revisit in the future.




More information about the All-commits mailing list