[all-commits] [llvm/llvm-project] f175b9: Improve VSCode DAP logpoint value summary (#71723)

jeffreytan81 via All-commits all-commits at lists.llvm.org
Wed Nov 8 16:49:08 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f175b9647ccdfd67300264b2d3bd76e6f9a3fb93
      https://github.com/llvm/llvm-project/commit/f175b9647ccdfd67300264b2d3bd76e6f9a3fb93
  Author: jeffreytan81 <jeffreytan at meta.com>
  Date:   2023-11-08 (Wed, 08 Nov 2023)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_logpoints.py
    M lldb/test/API/tools/lldb-dap/breakpoint/main.cpp
    M lldb/tools/lldb-dap/BreakpointBase.cpp
    M lldb/tools/lldb-dap/JSONUtils.cpp
    M lldb/tools/lldb-dap/JSONUtils.h

  Log Message:
  -----------
  Improve VSCode DAP logpoint value summary (#71723)

Currently VSCode logpoint uses `SBValue::GetValue` to get the value for
printing. This is not providing an intuitive result for std::string or
char * -- it shows the pointer value instead of the string content.

This patch improves by prefers `SBValue::GetSummary()` before using
`SBValue::GetValue()`.

---------

Co-authored-by: jeffreytan81 <jeffreytan at fb.com>




More information about the All-commits mailing list