[all-commits] [llvm/llvm-project] 03a92f: [lldb] BreakpointResolver{*}::CreateFromStructured...

Alex Langford via All-commits all-commits at lists.llvm.org
Tue Nov 7 11:22:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 03a92f0ecabdf8065f4458a780484db92f032d14
      https://github.com/llvm/llvm-project/commit/03a92f0ecabdf8065f4458a780484db92f032d14
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M lldb/include/lldb/Breakpoint/BreakpointResolverAddress.h
    M lldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h
    M lldb/include/lldb/Breakpoint/BreakpointResolverFileRegex.h
    M lldb/include/lldb/Breakpoint/BreakpointResolverName.h
    M lldb/include/lldb/Breakpoint/BreakpointResolverScripted.h
    M lldb/source/Breakpoint/BreakpointResolver.cpp
    M lldb/source/Breakpoint/BreakpointResolverAddress.cpp
    M lldb/source/Breakpoint/BreakpointResolverFileLine.cpp
    M lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp
    M lldb/source/Breakpoint/BreakpointResolverName.cpp
    M lldb/source/Breakpoint/BreakpointResolverScripted.cpp

  Log Message:
  -----------
  [lldb] BreakpointResolver{*}::CreateFromStructuredData should return shared pointers (#71477)

BreakpointResolver::CreateFromStructuredData returns a
BreakpointResolverSP, but all of the subclasses return raw pointers.
Instead of creating a raw pointer and shoving it into a shared pointer,
it seems reasonable to just create the shared pointer directly.




More information about the All-commits mailing list