[all-commits] [llvm/llvm-project] 799141: [lldb/Interpreter] Make Scripted*Interface base cl...

Med Ismail Bennani via All-commits all-commits at lists.llvm.org
Tue Nov 7 09:56:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7991412270ce1147ca0ab286e2479b5381a564ad
      https://github.com/llvm/llvm-project/commit/7991412270ce1147ca0ab286e2479b5381a564ad
  Author: Med Ismail Bennani <ismail at bennani.ma>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M lldb/include/lldb/Interpreter/Interfaces/ScriptedPlatformInterface.h
    M lldb/include/lldb/Interpreter/Interfaces/ScriptedProcessInterface.h
    M lldb/include/lldb/Interpreter/Interfaces/ScriptedThreadInterface.h
    M lldb/include/lldb/Interpreter/ScriptInterpreter.h
    M lldb/source/Interpreter/ScriptInterpreter.cpp
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

  Log Message:
  -----------
  [lldb/Interpreter] Make Scripted*Interface base class abstract (#71465)

This patch makes the various Scripted Interface base class abstract by
making the `CreatePluginObject` method pure virtual.

This means that we cannot construct a Scripted Interface base class
instance, so this patch also updates the various
`ScriptedInterpreter::CreateScripted*Interface` methods to return a
`nullptr` instead.`

This patch also removes the `ScriptedPlatformInterface` member from the
`ScriptInterpreter` class since it the interpreter can be owned by the
`ScriptedPlatform` instance itself, like we do for `ScriptedProcess`
objects.

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>




More information about the All-commits mailing list