[all-commits] [llvm/llvm-project] 2c4f93: Reapply #2 [clang-repl] [test] Make an XFAIL more ...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2c4f938f1c01794d9b944c24e9067eac6763e95c
      https://github.com/llvm/llvm-project/commit/2c4f938f1c01794d9b944c24e9067eac6763e95c
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M clang/test/Interpreter/const.cpp
    M llvm/test/lit.cfg.py
    M llvm/utils/lit/lit/llvm/config.py

  Log Message:
  -----------
  Reapply #2 [clang-repl] [test] Make an XFAIL more precise (#71168)

The const.cpp testcase fails when running in MSVC mode, while it does
succeed in MinGW mode.

In MSVC mode, there are more constructor invocations than expected, as
the printout looks like this:

    A(1), this = 0000025597930000
    A(1), this = 0000025597930000
    f: this = 0000025597930000, val = 1
    A(1), this = 0000025597930000
    f: this = 0000025597930000, val = 1
    ~A, this = 0000025597930000, val = 1
    ~A, this = 0000025597930000, val = 1
    ~A, this = 0000025597930000, val = 1

While the expected printout looks like this:

    A(1), this = 000002C903E10000
    f: this = 000002C903E10000, val = 1
    f: this = 000002C903E10000, val = 1
    ~A, this = 000002C903E10000, val = 1

Reapplying #70991 with the XFAIL changed to check the host triple, not
the target triple. On an MSVC based build of Clang, but with the default
target triple set to PS4/PS5, we will still see the failure. And a Linux
based build of Clang that targets PS4/PS5 won't see the issue.