[all-commits] [llvm/llvm-project] b3857b: [libc++][NFC] Make data members of counted_iterato...

Louis Dionne via All-commits all-commits at lists.llvm.org
Mon Nov 6 11:23:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b3857b2ecfd7064ed39aa9ae5a74c105550a05e3
      https://github.com/llvm/llvm-project/commit/b3857b2ecfd7064ed39aa9ae5a74c105550a05e3
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M libcxx/include/__iterator/counted_iterator.h

  Log Message:
  -----------
  [libc++][NFC] Make data members of counted_iterator private (#70491)

There's no reason for them to be public AFAICT. I came across this while
auditing the code bases for places where we'd be using
[[no_unique_address]] incorrectly. Since one of these members is marked
as [[no_unique_address]], this is an extra reason to keep this private
to ensure the member isn't escaped anywhere.




More information about the All-commits mailing list