[all-commits] [llvm/llvm-project] 87b00e: [libc][bazel] Prevent LIBC_NAMESPACE leakeage (#70...

Guillaume Chatelet via All-commits all-commits at lists.llvm.org
Mon Nov 6 07:56:09 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 87b00ef35a0060e29fbc771e8557600e396f966c
      https://github.com/llvm/llvm-project/commit/87b00ef35a0060e29fbc771e8557600e396f966c
  Author: Guillaume Chatelet <gchatelet at google.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M utils/bazel/llvm-project-overlay/libc/BUILD.bazel
    M utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
    M utils/bazel/llvm-project-overlay/libc/test/UnitTest/BUILD.bazel
    M utils/bazel/llvm-project-overlay/libc/test/libc_test_rules.bzl
    M utils/bazel/llvm-project-overlay/libc/test/src/__support/CPP/BUILD.bazel
    M utils/bazel/llvm-project-overlay/libc/test/src/math/BUILD.bazel
    M utils/bazel/llvm-project-overlay/libc/test/src/stdlib/BUILD.bazel
    M utils/bazel/llvm-project-overlay/libc/test/src/string/BUILD.bazel
    M utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel

  Log Message:
  -----------
  [libc][bazel] Prevent LIBC_NAMESPACE leakeage (#70455)

Right now `LIBC_NAMESPACE` definition is added to all rules that depend on any libc function. This have far-reaching effects which prevents llvm-libc development when the installed libc is itself llvm-libc.

This PR removes the `:libc_root` target entirely and consistently uses the provided libc BUILD actions for compilation and testing. This makes sure that we don't leak `LIBC_NAMESPACE` to our clients.




More information about the All-commits mailing list