[all-commits] [llvm/llvm-project] b14250: [mlir][memref] Fix segfault in SROA (#71063)

[Théo Degioanni via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b142501e9267e308b6b6e5a051f327aa1e0ee3b7
      https://github.com/llvm/llvm-project/commit/b142501e9267e308b6b6e5a051f327aa1e0ee3b7
  Author: Théo Degioanni <30992420+Moxinilian at users.noreply.github.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M mlir/lib/Dialect/MemRef/IR/MemRefMemorySlot.cpp
    M mlir/test/Dialect/MemRef/sroa.mlir

  Log Message:
  -----------
  [mlir][memref] Fix segfault in SROA (#71063)

Fixes #70902.

The out of bounds check in the SROA implementation for MemRef was not
actually testing anything because it only operated on a store op which
does not trigger the logic by itself. It is now checked for real and the
underlying bug is fixed.

I checked the LLVM implementation just in case but this should not
happen as out-of-bound checks happen in GEP's verifier there.