[all-commits] [llvm/llvm-project] 890335: [InstrProf] Do not block functions from PGOUse (#7...

[Ellis Hoag via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 890335bb28b96ab09ce3d6cf9c2e611bcabb36eb
      https://github.com/llvm/llvm-project/commit/890335bb28b96ab09ce3d6cf9c2e611bcabb36eb
  Author: Ellis Hoag <ellis.sparky.hoag at gmail.com>
  Date:   2023-11-03 (Fri, 03 Nov 2023)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp

  Log Message:
  -----------
  [InstrProf] Do not block functions from PGOUse (#71106)

The `skipPGO()` function was added in https://reviews.llvm.org/D137184.
Unfortunately, it also blocked functions from being annotated (PGOUse),
which I believe will cause confusion to users if a function has a
profile but it is not PGO'd.

The docs for `noprofile` and `skipprofile` only claim to block
instrumentation, not PGO optimization:
https://llvm.org/docs/LangRef.html