[all-commits] [llvm/llvm-project] e9db60: Reapply [clang-repl] [test] Make an XFAIL more pre...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Fri Nov 3 02:30:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e9db60c05e2fb96ff40cbb1f78790abc5de9237e
      https://github.com/llvm/llvm-project/commit/e9db60c05e2fb96ff40cbb1f78790abc5de9237e
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-11-03 (Fri, 03 Nov 2023)

  Changed paths:
    M clang/test/Interpreter/const.cpp

  Log Message:
  -----------
  Reapply [clang-repl] [test] Make an XFAIL more precise (#70991)

The const.cpp testcase fails when running in MSVC mode, while it does
succeed in MinGW mode.

In MSVC mode, there are more constructor invocations than expected, as
the printout looks like this:

    A(1), this = 0000025597930000
    A(1), this = 0000025597930000
    f: this = 0000025597930000, val = 1
    A(1), this = 0000025597930000
    f: this = 0000025597930000, val = 1
    ~A, this = 0000025597930000, val = 1
    ~A, this = 0000025597930000, val = 1
    ~A, this = 0000025597930000, val = 1

While the expected printout looks like this:

    A(1), this = 000002C903E10000
    f: this = 000002C903E10000, val = 1
    f: this = 000002C903E10000, val = 1
    ~A, this = 000002C903E10000, val = 1

Reapplying with the XFAIL pattern expanded to include PS4/PS5
triples as well, which also seem to have the same behaviour
as MSVC.




More information about the All-commits mailing list