[all-commits] [llvm/llvm-project] fd95f3: Revert "[CaptureTracking] Ignore ephemeral values ...

[Florian Hahn via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fd95f398c7623ff4a62e5001b4cde21c5b9eb111
      https://github.com/llvm/llvm-project/commit/fd95f398c7623ff4a62e5001b4cde21c5b9eb111
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Analysis/AliasAnalysis.h
    M llvm/include/llvm/Analysis/CaptureTracking.h
    M llvm/lib/Analysis/BasicAliasAnalysis.cpp
    M llvm/lib/Analysis/CaptureTracking.cpp
    M llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
    M llvm/test/Transforms/DeadStoreElimination/assume.ll

  Log Message:
  -----------
  Revert "[CaptureTracking] Ignore ephemeral values when determining po… (#71066)

Unfortunately the commit (D123162) introduced a mis-compile
(https://github.com/llvm/llvm-project/issues/70547), which wasn't fixed
by the alternative fix (c0de28b92e98acbeb73)

I think as long as the call considered as ephemeral is not removed, we
need to be conservative. To address the correctness issue quickly, I
think we should revert the patch (as this patch does, it doens't revert
cleanly)

This reverts commit 17fdaccccfad9b143e4aadbcdda7f645de127153.

Fixes https://github.com/llvm/llvm-project/issues/70547