[all-commits] [llvm/llvm-project] 43feb3: [clang] Separate bit-field padding diagnostics int...

[Dan Klishch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43feb3eeb1ba4de920d6eaa12b7a5c21f6dd6229
      https://github.com/llvm/llvm-project/commit/43feb3eeb1ba4de920d6eaa12b7a5c21f6dd6229
  Author: Dan Klishch <30951924+DanShaders at users.noreply.github.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticASTKinds.td
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/lib/AST/RecordLayoutBuilder.cpp
    M clang/test/CodeGenCXX/warn-all-padded-packed-packed-non-pod.cpp
    A clang/test/CodeGenCXX/warn-padded-bitfields.cpp

  Log Message:
  -----------
  [clang] Separate bit-field padding diagnostics into -Wpadded-bitfield (#70978)

The `-Wpadded` diagnostics are usually very noisy and generally not
helpful. However, reporting padding that was introduced in bit-fields is
rather helpful. For example, yesterday in SerenityOS's discord we had
very unpleasant experience of debugging Windows portability issue, and
its root cause was that under `x86_64-pc-windows-msvc` a padding was
introduced for one of the bit-fields.

So, this PR separates bit-field-related padding diagnostics into a new
`-Wpadded-bitfield`. The diagnostic group is also enabled by `-Wpadded`
for compatibility reasons.