[all-commits] [llvm/llvm-project] 43db8a: [lldb] Fix missing comsumeError() with LLDB_LOG in...

[Stefan Gränitz via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43db8ac8ae56f24b5c06e9edb194fe1b7e9cbda0
      https://github.com/llvm/llvm-project/commit/43db8ac8ae56f24b5c06e9edb194fe1b7e9cbda0
  Author: Stefan Gränitz <weliveindetail at users.noreply.github.com>
  Date:   2023-11-01 (Wed, 01 Nov 2023)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp
    M lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

  Log Message:
  -----------
  [lldb] Fix missing comsumeError() with LLDB_LOG in ObjectFileCOFF/PECOFF (#70793)

All `llvm::Error`s must be checked/consumed before destruction. Previously,
the errors in this patch were only consumed when logging was enabled.
Using `LLDB_LOG_ERROR` instead of `LLDB_LOG` fixes that, because it
calls `llvm::consumeError()` explicitly when logging is disabled.