[all-commits] [llvm/llvm-project] 73c624: [mlir][MemRefToLLVM] Fix crashes with unconvertabl...

[Krzysztof Drewniak via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 73c6248cc2cc3acd01c3580bfdc64825c09a0fd6
      https://github.com/llvm/llvm-project/commit/73c6248cc2cc3acd01c3580bfdc64825c09a0fd6
  Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
  Date:   2023-10-31 (Tue, 31 Oct 2023)

  Changed paths:
    M mlir/lib/Conversion/MemRefToLLVM/AllocLikeConversion.cpp
    M mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp
    M mlir/test/Conversion/MemRefToLLVM/invalid.mlir
    A mlir/test/Conversion/MemRefToLLVM/issue-70160.mlir

  Log Message:
  -----------
  [mlir][MemRefToLLVM] Fix crashes with unconvertable memory spaces (#70694)

Fixes #70160

The issue is resolved by:
1. Changing the call to address space conversion to use the correct
return type, preventing the code from moving past the if and into the
crashing optional dereference.
2. Adding handling to the AllocLikeOp rewriter for the case where the
underlying buffer allocation fails.