[all-commits] [llvm/llvm-project] 68c384: [Flang][MLIR][OpenMP] Temporarily re-add basic han...

agozillon via All-commits all-commits at lists.llvm.org
Mon Oct 30 13:10:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 68c384676cf92289d823576f915ed296d209354f
      https://github.com/llvm/llvm-project/commit/68c384676cf92289d823576f915ed296d209354f
  Author: Andrew Gozillon <Andrew.Gozillon at amd.com>
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M openmp/libomptarget/test/offloading/fortran/basic-target-region-1D-array-section.f90
    M openmp/libomptarget/test/offloading/fortran/basic-target-region-3D-array-section.f90
    M openmp/libomptarget/test/offloading/fortran/basic-target-region-3D-array.f90

  Log Message:
  -----------
  [Flang][MLIR][OpenMP] Temporarily re-add basic handling of uses in target regions to avoid gfortran test-suite regressions

This was a regression introduced by myself in:

 https://github.com/llvm/llvm-project/commit/6a62707c048e16ce9bad37ed8e3520799139436b

where I too hastily removed the basic handling of implicit captures
we have currently. This will be superseded by all implicit captures
being added to target operations map_info entries in a soon landing
series of patches, however, that is currently not the case so we must
continue to do some basic handling of these captures for the time
being. This patch re-adds that behaviour to avoid regressions.

Unfortunately this means some test changes as well as
getUsedValuesDefinedAbove grabs constants used outside
of the target region which aren't handled particularly
well currently.




More information about the All-commits mailing list