[all-commits] [llvm/llvm-project] bb9dce: [lldb][AArch64][Linux] Rename Is<ext>Enabled to Is...

David Spickett via All-commits all-commits at lists.llvm.org
Mon Oct 30 08:45:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bb9dced2d3b479fc47221a25eae496f15c573c3c
      https://github.com/llvm/llvm-project/commit/bb9dced2d3b479fc47221a25eae496f15c573c3c
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
    M lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
    M lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.h
    M lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp

  Log Message:
  -----------
  [lldb][AArch64][Linux] Rename Is<ext>Enabled to Is<ext>Present (#70303)

For most register sets, if it was enabled this meant you could use it,
it was present in the process. There was no present but turned off
state. So "enabled" made sense.

Then ZA came along (and soon to be ZT0) where ZA can be present in the
hardware when you have SME, but ZA itself can be made inactive. This
means that "IsZAEnabled()" doesn't mean is it active, it means do you
have SME. Which is very confusing when we actually want to know if ZA is
active.

So instead say "IsZAPresent", to make these checks more specific. For
things that can't be made inactive, present will imply "active" as
they're never inactive.




More information about the All-commits mailing list