[all-commits] [llvm/llvm-project] ab261e: [flang] Do not stop on mismatched DATA substring l...

jeanPerier via All-commits all-commits at lists.llvm.org
Sun Oct 22 23:54:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ab261eb38a6efaf3f3290400f9f60312aaffff0a
      https://github.com/llvm/llvm-project/commit/ab261eb38a6efaf3f3290400f9f60312aaffff0a
  Author: jeanPerier <jperier at nvidia.com>
  Date:   2023-10-23 (Mon, 23 Oct 2023)

  Changed paths:
    M flang/include/flang/Evaluate/initial-image.h
    M flang/lib/Semantics/data-to-inits.cpp
    A flang/test/Semantics/data19.f90

  Log Message:
  -----------
  [flang] Do not stop on mismatched DATA substring length (#69336)

https://reviews.llvm.org/D143819 turned mismatched DATA substring from a
crash into a warning. However, the resulting DATA was incorrect when
there were subsequent DATA values after the mismatch because the DATA to
init conversion stopped. This change let the DATA to init continue.

I added a LengthMismatch tag instead of using SizeMismatch because the
other situation where SizeMismatch is returned seem like bug situations
to me (the DATA value is dropped and the offset is not advanced), so I
did not want to continue DATA processing in these cases.




More information about the All-commits mailing list