[all-commits] [llvm/llvm-project] 74ca07: [lldb] improve dwo path in missing dwo error when ...

[Tom Yang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 74ca07295f3224a77ea5202858b3f4195b23fbcf
      https://github.com/llvm/llvm-project/commit/74ca07295f3224a77ea5202858b3f4195b23fbcf
  Author: Tom Yang <zhenyutyang at gmail.com>
  Date:   2023-10-21 (Sat, 21 Oct 2023)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    A lldb/test/Shell/SymbolFile/DWARF/Inputs/dwo-missing-error.c
    A lldb/test/Shell/SymbolFile/DWARF/dwo-missing-error.test

  Log Message:
  -----------
  [lldb] improve dwo path in missing dwo error when relative (#69783)

When the debug info refers to a dwo with relative `DW_AT_comp_dir` and
`DW_AT_dwo_name`, we only print the `DW_AT_comp_dir` in our error
message if we can't find it. This often isn't very helpful, especially
when the `DW_AT_comp_dir` is ".":
```
(lldb) fr v
error: unable to locate .dwo debug file "." for skeleton DIE 0x000000000000003c
```

I'm updating the error message to include both `DW_AT_comp_dir` (if it
exists) and `DW_AT_dwo_name` when the `DW_AT_dwo_name` is relative. The
behavior when `DW_AT_dwo_name` is absolute should be the same.