[all-commits] [llvm/llvm-project] a67ae8: [LLD] [COFF] Add a separate option for allowing du...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a67ae8c0fd301a11e2a058e8035304cfc70a3e91
      https://github.com/llvm/llvm-project/commit/a67ae8c0fd301a11e2a058e8035304cfc70a3e91
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    M lld/COFF/Config.h
    M lld/COFF/Driver.cpp
    M lld/COFF/InputFiles.cpp
    M lld/COFF/Options.td
    M lld/test/COFF/gnu-weak.test

  Log Message:
  -----------
  [LLD] [COFF] Add a separate option for allowing duplicate weak symbols (#68077)

The MinGW mode (enabled with the flag -lldmingw) does allow duplicate
weak symbols. A test in
compiler-rt/test/profile/Windows/coverage-weak-lld.cpp does currently
enable the -lldmingw flag in an MSVC context, in order to deal with
duplicate weak symbols.

Add a new, separate, lld specific flag for enabling this. In MinGW mode,
this is enabled by default, otherwise it is disabled.

This allows making the MinGW mode more restrictive in adding libpaths
from the surrounding environment; in MinGW mode, all libpaths are passed
explicitly by the compiler driver to the linker, which is attempted in
https://reviews.llvm.org/D144084.