[all-commits] [llvm/llvm-project] 049993: [FunctionComparator] Differentiate instructions pa...

[Nuri Amari via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 049993eae6bef539ac4bca7ddeede78282e496d9
      https://github.com/llvm/llvm-project/commit/049993eae6bef539ac4bca7ddeede78282e496d9
  Author: Nuri Amari <nuriamari at meta.com>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M llvm/lib/Transforms/Utils/FunctionComparator.cpp
    A llvm/test/Transforms/MergeFunc/mergefunc-preserve-vfe-intrinsics.ll

  Log Message:
  -----------
  [FunctionComparator] Differentiate instructions passing different MDStrings (#69543)

Prior to this patch, differing metadata operands to two otherwise
identical instructions was not enough to consider the instructions
different in the eyes of the function comparator. This breaks LLVM
virtual function elimination, among other features.

In this patch, we handle the case where two associated operands are
MDStrings of different value. This patch does not differentiate more
complex metadata operands.

---------

Co-authored-by: Nuri Amari <nuriamari at fb.com>