[all-commits] [llvm/llvm-project] 3e49ce: InlineSpiller: Delete assert that implicit_def has...

[Matt Arsenault via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3e49ce6ea16ec7e1c580ab785992b773a37f270c
      https://github.com/llvm/llvm-project/commit/3e49ce6ea16ec7e1c580ab785992b773a37f270c
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    M llvm/lib/CodeGen/InlineSpiller.cpp
    A llvm/test/CodeGen/AArch64/implicit-def-with-impdef-greedy-assert.mir
    A llvm/test/CodeGen/X86/inline-spiller-impdef-on-implicit-def-regression.ll

  Log Message:
  -----------
  InlineSpiller: Delete assert that implicit_def has no implicit operands (#69087)

It's not a verifier enforced property that implicit_def may only have
one operand. Fixes assertions after the coalescer implicit-defs to
preserve super register liveness to arbitrary instructions.

For some reason I'm unable to reproduce this as a MIR test running only
the allocator for the x86 test. Not sure it's worth keeping around.