[all-commits] [llvm/llvm-project] f68122: [mlir][transform] Support symlinks in module loadi...

[Ingo Müller via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f68122570091445a63a18eb45e4ad3d0015b3070
      https://github.com/llvm/llvm-project/commit/f68122570091445a63a18eb45e4ad3d0015b3070
  Author: Ingo Müller <ingomueller at google.com>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
    R mlir/test/Dialect/Transform/Library/lower-to-llvm.mlir
    A mlir/test/Dialect/Transform/include/Library/lower-to-llvm.mlir
    A mlir/test/Dialect/Transform/include/test-interpreter-external-concurrent-source.mlir
    A mlir/test/Dialect/Transform/include/test-interpreter-external-source.mlir
    A mlir/test/Dialect/Transform/include/test-interpreter-external-symbol-def-invalid.mlir
    A mlir/test/Dialect/Transform/include/test-interpreter-library/definitions-self-contained.mlir
    A mlir/test/Dialect/Transform/include/test-interpreter-library/definitions-with-unresolved.mlir
    M mlir/test/Dialect/Transform/preload-library.mlir
    R mlir/test/Dialect/Transform/test-interpreter-external-concurrent-source.mlir
    M mlir/test/Dialect/Transform/test-interpreter-external-concurrent.mlir
    R mlir/test/Dialect/Transform/test-interpreter-external-source.mlir
    M mlir/test/Dialect/Transform/test-interpreter-external-symbol-decl-and-schedule.mlir
    M mlir/test/Dialect/Transform/test-interpreter-external-symbol-decl-dir.mlir
    M mlir/test/Dialect/Transform/test-interpreter-external-symbol-decl-invalid.mlir
    M mlir/test/Dialect/Transform/test-interpreter-external-symbol-decl.mlir
    R mlir/test/Dialect/Transform/test-interpreter-external-symbol-def-invalid.mlir
    M mlir/test/Dialect/Transform/test-interpreter-external.mlir
    R mlir/test/Dialect/Transform/test-interpreter-library/definitions-self-contained.mlir
    R mlir/test/Dialect/Transform/test-interpreter-library/definitions-with-unresolved.mlir
    M utils/bazel/llvm-project-overlay/mlir/test/Dialect/BUILD.bazel

  Log Message:
  -----------
  [mlir][transform] Support symlinks in module loading. Reorganize tests. (#69329)

A recent commit (#69190) broke the bazel builds. Turns out that Bazel
uses symlinks for providing the test files, which the path expansion of
the module loading mechanism did not handle correctly. This PR fixes
that.

It also reorganizes the tests better: It puts all `.mlir` files that are
included by some other test into a common `include` folder. This greatly
simplifies the definition of the dependencies between the different
`.mlir` files in Bazel's `BUILD` file. The commit also adds a comment to
all included files why these aren't tested themselves direclty and uses
the `%{fs-sep}` expansion for paths more consistently. Finally, it
uncomments all but one of the tests excluded in Bazel because they seem
to run now. (The remaining one includes a file that it itself a test, so
it would have to live *in* and *outside* of the `include` folder.)