[all-commits] [llvm/llvm-project] 22e3bf: [mlir][transform] Fix new interpreter and library ...

[Ingo Müller via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 22e3bf4eaf6cbbd387a3789e7ee082434e62d072
      https://github.com/llvm/llvm-project/commit/22e3bf4eaf6cbbd387a3789e7ee082434e62d072
  Author: Ingo Müller <ingomueller at google.com>
  Date:   2023-10-17 (Tue, 17 Oct 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/Transform/Transforms/Passes.td
    M mlir/lib/Dialect/Transform/Transforms/InterpreterPass.cpp
    A mlir/test/Dialect/Transform/interpreter-entry-point.mlir
    A mlir/test/Dialect/Transform/interpreter.mlir
    A mlir/test/Dialect/Transform/preload-library.mlir

  Log Message:
  -----------
  [mlir][transform] Fix new interpreter and library preloading passes. (#69190)

This PR fixes the two recently added passes from #68661, which were
non-functional and untested. In particular:
* The passes did not declare their dependent dialects, so they could not
run at all in the most simple cases.
* The mechanism of loading the library module in the initialization of
the intepreter pass is broken by design (but, fortunately, also not
necessary). This is because the initialization of all passes happens
before the execution of any other pass, so the "preload library" pass
has not run yet at the time the interpreter pass gets initialized.
Instead, the library is now loaded every time the interpreter pass is
run. This should not be exceedingly expensive, since it only consists of
looking up the library in the dialect. Also, this removes the library
module from the pass state, making it possible in the future to preload
libraries in several passes.
* The PR adds tests for the two passes, which were completely untested
previously.