[all-commits] [llvm/llvm-project] 499d41: [flang][OpenMP] Fix threadprivate common blocks (#...

Leandro Lupori via All-commits all-commits at lists.llvm.org
Mon Oct 16 05:13:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 499d41cef2e7bbb65804f6a815b9fa8b27efce0f
      https://github.com/llvm/llvm-project/commit/499d41cef2e7bbb65804f6a815b9fa8b27efce0f
  Author: Leandro Lupori <leandro.lupori at linaro.org>
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
    M flang/lib/Semantics/resolve-directives.cpp
    A flang/test/Semantics/OpenMP/threadprivate06.f90

  Log Message:
  -----------
  [flang][OpenMP] Fix threadprivate common blocks (#68739)

Using a threadprivate common block within a nested scope resulted
in compilation errors.

This happened because common block names were being first resolved
to those in the parent scope. Because of this, in a nested scope,
an inner threadprivate directive would be applied to the outter
common block. This caused a 'common_block appears in more than one
data-sharing clause' error.

Also, when a copyin clause in a parallel region tried to use the
common block, getting the inner version of it, their objects would
be missing the threadprivate attribute, causing a 'Non-THREADPRIVATE
object in COPYIN clause' error.

Fixes https://github.com/llvm/llvm-project/issues/61200




More information about the All-commits mailing list